Patchew URL: https://patchew.org/QEMU/20181214144214.1260-1-peter.mayd...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181214144214.1260-1-peter.mayd...@linaro.org Type: series Subject: [Qemu-devel] [PULL 00/22] misc queue === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' a270d9d virt: Fix broken indentation cbd1ee0 target/arm: Create timers in realize, not init dc7dad8 tests/test-arm-mptimer: Don't leak string memory 515636e hw/sd/sdhci: Don't leak memory region in sdhci_sysbus_realize() e774828 hw/arm/mps2-tz.c: Free mscname string in make_dma() 3ddd560 target/arm: Free name string in ARMCPRegInfo hashtable entries 98bd688 include/hw/loader.h: Document load_image_size() 8cc4663 hw/core/loader.c: Remove load_image() 200adc0 device_tree.c: Don't use load_image() a168dfe hw/block/tc58128.c: Don't use load_image() 03e819b hw/i386/multiboot.c: Don't use load_image() 7773750 hw/i386/pc.c: Don't use load_image() deef451 hw/pci/pci.c: Don't use load_image() bc9b210 hw/smbios/smbios.c: Don't use load_image() 8561b4f hw/ppc/ppc405_boards: Don't use load_image() 6fa8785 hw/ppc/mac_newworld, mac_oldworld: Don't use load_image() c2fa852 elf_ops.h: Use address_space_write() to write memory 6b5a590 monitor: Use address_space_read() to read memory 204baf1 disas.c: Use address_space_read() to read memory 5b75a36 Rename cpu_physical_memory_write_rom() to address_space_write_rom() 247aebb exec.c: Rename cpu_physical_memory_write_rom_internal() 9230e2d scripts/checkpatch.pl: Enforce multiline comment syntax === OUTPUT BEGIN === Checking PATCH 1/22: scripts/checkpatch.pl: Enforce multiline comment syntax... WARNING: line over 80 characters #44: FILE: scripts/checkpatch.pl:1576: + $rawline =~ m@^\+.*/\*\*?[ \t]*.+[ \t]*$@) { # /* or /** non-blank ERROR: line over 90 characters #45: FILE: scripts/checkpatch.pl:1577: + WARN("Block comments use a leading /* on a separate line\n" . $herecurr); WARNING: line over 80 characters #54: FILE: scripts/checkpatch.pl:1586: + WARN("Block comments use * on subsequent lines\n" . $hereprev); ERROR: line over 90 characters #62: FILE: scripts/checkpatch.pl:1594: + WARN("Block comments use a trailing */ on a separate line\n" . $herecurr); ERROR: line over 90 characters #84: FILE: scripts/checkpatch.pl:1616: + WARN("Block comments should align the * on each line\n" . $hereprev); total: 3 errors, 2 warnings, 54 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/22: exec.c: Rename cpu_physical_memory_write_rom_internal()... WARNING: line over 80 characters #39: FILE: exec.c:3396: + enum write_rom_type type) total: 0 errors, 1 warnings, 50 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/22: Rename cpu_physical_memory_write_rom() to address_space_write_rom()... WARNING: Block comments use a leading /* on a separate line #190: FILE: include/exec/memory.h:1795: +/** total: 0 errors, 1 warnings, 156 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/22: disas.c: Use address_space_read() to read memory... Checking PATCH 5/22: monitor: Use address_space_read() to read memory... Checking PATCH 6/22: elf_ops.h: Use address_space_write() to write memory... Checking PATCH 7/22: hw/ppc/mac_newworld, mac_oldworld: Don't use load_image()... Checking PATCH 8/22: hw/ppc/ppc405_boards: Don't use load_image()... Checking PATCH 9/22: hw/smbios/smbios.c: Don't use load_image()... Checking PATCH 10/22: hw/pci/pci.c: Don't use load_image()... Checking PATCH 11/22: hw/i386/pc.c: Don't use load_image()... Checking PATCH 12/22: hw/i386/multiboot.c: Don't use load_image()... Checking PATCH 13/22: hw/block/tc58128.c: Don't use load_image()... Checking PATCH 14/22: device_tree.c: Don't use load_image()... Checking PATCH 15/22: hw/core/loader.c: Remove load_image()... Checking PATCH 16/22: include/hw/loader.h: Document load_image_size()... WARNING: Block comments use a leading /* on a separate line #24: FILE: include/hw/loader.h:14: +/** total: 0 errors, 1 warnings, 22 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 17/22: target/arm: Free name string in ARMCPRegInfo hashtable entries... Checking PATCH 18/22: hw/arm/mps2-tz.c: Free mscname string in make_dma()... Checking PATCH 19/22: hw/sd/sdhci: Don't leak memory region in sdhci_sysbus_realize()... Checking PATCH 20/22: tests/test-arm-mptimer: Don't leak string memory... Checking PATCH 21/22: target/arm: Create timers in realize, not init... Checking PATCH 22/22: virt: Fix broken indentation... === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20181214144214.1260-1-peter.mayd...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com