Hi
On Tue, Jan 15, 2019 at 6:53 PM Daniel P. Berrangé <berra...@redhat.com> wrote:
>
> If no valid char driver was identified the qemu_chr_parse_compat method
> was silent, leaving callers no clue what failed.
>
> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> chardev/char.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/chardev/char.c b/chardev/char.c
> index ccba36bafb..b99f3692f7 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -490,6 +490,8 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const
> char *filename,
> return opts;
> }
>
> + error_report("'%s' is not a valid char driver", filename);
> +
> fail:
> qemu_opts_del(opts);
> return NULL;
> --
> 2.20.1
>
