Re: [Qemu-devel] [PATCH v6 11/11] hw/pvrdma: Provide correct value to object_get_typename

[Kamal Heib]

On 3/11/19 12:29 PM, Yuval Shaia wrote:
> Use base object of PCIDevice in call to object_get_typename().
> 
> Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com>
> ---
>  hw/rdma/vmw/pvrdma_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
> index 49bfbd6..0b46561 100644
> --- a/hw/rdma/vmw/pvrdma_main.c
> +++ b/hw/rdma/vmw/pvrdma_main.c
> @@ -593,7 +593,7 @@ static void pvrdma_realize(PCIDevice *pdev, Error **errp)
>  
>      func0 = pci_get_function_0(pdev);
>      /* Break if not vmxnet3 device in slot 0 */
> -    if (strcmp(object_get_typename(&func0->qdev.parent_obj), TYPE_VMXNET3)) {
> +    if (strcmp(object_get_typename(OBJECT(func0)), TYPE_VMXNET3)) {
>          error_setg(errp, "Device on %x.0 must be %s", PCI_SLOT(pdev->devfn),
>                     TYPE_VMXNET3);
>          return;
> 

Reviewed-by: Kamal Heib <kamalhe...@gmail.com>