Re: [Qemu-devel] [PATCH v6 10/11] hw/pvrdma: Unregister from shutdown notifier when device goes down

[Kamal Heib]

On 3/11/19 12:29 PM, Yuval Shaia wrote:
> This hook was installed to close the device when VM is going down.
> After the device is closed there is no need to be informed on VM
> shutdown.
> 
> Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com>
> Reviewed-by: Marcel Apfelbaum <marcel.apfelb...@gmail.com>
> ---
>  hw/rdma/vmw/pvrdma_main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
> index a4afced..49bfbd6 100644
> --- a/hw/rdma/vmw/pvrdma_main.c
> +++ b/hw/rdma/vmw/pvrdma_main.c
> @@ -311,6 +311,8 @@ static void pvrdma_fini(PCIDevice *pdev)
>  {
>      PVRDMADev *dev = PVRDMA_DEV(pdev);
>  
> +    notifier_remove(&dev->shutdown_notifier);
> +
>      pvrdma_qp_ops_fini();
>  
>      rdma_backend_stop(&dev->backend_dev);
> 

Reviewed-by: Kamal Heib <kamalhe...@gmail.com>