Patchew URL: https://patchew.org/QEMU/20190618143923.53838-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH RESEND v21 00/21] Add RX archtecture support Type: series Message-id: 20190618143923.53838-1-ys...@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu 34bea4edb9..33d6099906 master -> master From https://github.com/patchew-project/qemu * [new tag] patchew/20190618143923.53838-1-ys...@users.sourceforge.jp -> patchew/20190618143923.53838-1-ys...@users.sourceforge.jp Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Switched to a new branch 'test' 5d62ef962a BootLinuxConsoleTest: Test the RX-Virt machine 9d17094d81 Add rx-softmmu a14412155d hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 09e5efee5b hw/rx: Honor -accel qtest bf9fa4e3ab hw/rx: RX Target hardware definition f695d86e47 hw/char: RX62N serial communication interface (SCI) 6cd2f26fa4 hw/timer: RX62N internal timer modules 7b152289f3 hw/intc: RX62N interrupt controller (ICUa) de21df2c62 target/rx: Dump bytes for each insn during disassembly 49914423c8 target/rx: Collect all bytes during disassembly 519b2aaf90 target/rx: Emit all disassembly in one prt() e17524e8d0 target/rx: Use prt_ldmi for XCHG_mr disassembly 850bff8b4a target/rx: Replace operand with prt_ldmi in disassembler b5b096b382 target/rx: Disassemble rx_index_addr into a string 2389c3160d target/rx: RX disassembler 7c7864379e target/rx: CPU definition 81f1c7ceb0 target/rx: TCG helper 96065ad5fe target/rx: TCG translation 11cc429e75 hw/registerfields.h: Add 8bit and 16bit register macros 4225a75d72 qemu/bitops.h: Add extract8 and extract16 87f394a3f2 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/21 Checking commit 87f394a3f2c5 (MAINTAINERS: Add RX) 2/21 Checking commit 4225a75d721a (qemu/bitops.h: Add extract8 and extract16) 3/21 Checking commit 11cc429e7582 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/21 Checking commit 96065ad5fee9 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/21 Checking commit 81f1c7ceb0e8 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 5/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/21 Checking commit 7c7864379e0f (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 622 lines checked Patch 6/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/21 Checking commit 2389c3160d56 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/21 Checking commit b5b096b38224 (target/rx: Disassemble rx_index_addr into a string) 9/21 Checking commit 850bff8b4a0c (target/rx: Replace operand with prt_ldmi in disassembler) 10/21 Checking commit e17524e8d01d (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/21 Checking commit 519b2aaf90d0 (target/rx: Emit all disassembly in one prt()) 12/21 Checking commit 49914423c8c0 (target/rx: Collect all bytes during disassembly) 13/21 Checking commit de21df2c62e7 (target/rx: Dump bytes for each insn during disassembly) 14/21 Checking commit 7b152289f320 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 14/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/21 Checking commit 6cd2f26fa4d4 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 15/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/21 Checking commit f695d86e4759 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 16/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/21 Checking commit bf9fa4e3ab2d (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 479 lines checked Patch 17/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/21 Checking commit 09e5efee5b56 (hw/rx: Honor -accel qtest) 19/21 Checking commit a14412155d42 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/21 Checking commit 9d17094d812e (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 20/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/21 Checking commit 5d62ef962a3a (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190618143923.53838-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com