Patchew URL: https://patchew.org/QEMU/20190618143923.53838-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH RESEND v21 00/21] Add RX archtecture support Type: series Message-id: 20190618143923.53838-1-ys...@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu t [tag update] patchew/20190618143923.53838-1-ys...@users.sourceforge.jp -> patchew/20190618143923.53838-1-ys...@users.sourceforge.jp Switched to a new branch 'test' 1b70a2c5e3 BootLinuxConsoleTest: Test the RX-Virt machine b1b44ed680 Add rx-softmmu f313ac351c hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 57763b04f4 hw/rx: Honor -accel qtest bf58fbd6c2 hw/rx: RX Target hardware definition ece27860fa hw/char: RX62N serial communication interface (SCI) ed845484f2 hw/timer: RX62N internal timer modules e70e0f1b45 hw/intc: RX62N interrupt controller (ICUa) 31a1706ee1 target/rx: Dump bytes for each insn during disassembly f8f829a583 target/rx: Collect all bytes during disassembly 007f80fb96 target/rx: Emit all disassembly in one prt() 49aa581505 target/rx: Use prt_ldmi for XCHG_mr disassembly 32047e7e71 target/rx: Replace operand with prt_ldmi in disassembler 21717d9d51 target/rx: Disassemble rx_index_addr into a string d8ae8a9439 target/rx: RX disassembler b0c9d476a0 target/rx: CPU definition 3b5f51618c target/rx: TCG helper 0672f653d3 target/rx: TCG translation 98019e980a hw/registerfields.h: Add 8bit and 16bit register macros 79c6710c70 qemu/bitops.h: Add extract8 and extract16 e6d4fac88d MAINTAINERS: Add RX === OUTPUT BEGIN === 1/21 Checking commit e6d4fac88d91 (MAINTAINERS: Add RX) 2/21 Checking commit 79c6710c70ee (qemu/bitops.h: Add extract8 and extract16) 3/21 Checking commit 98019e980a8f (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/21 Checking commit 0672f653d3a0 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/21 Checking commit 3b5f51618ca8 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 5/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/21 Checking commit b0c9d476a072 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 622 lines checked Patch 6/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/21 Checking commit d8ae8a94394b (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/21 Checking commit 21717d9d5167 (target/rx: Disassemble rx_index_addr into a string) 9/21 Checking commit 32047e7e716d (target/rx: Replace operand with prt_ldmi in disassembler) 10/21 Checking commit 49aa581505c6 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/21 Checking commit 007f80fb96a8 (target/rx: Emit all disassembly in one prt()) 12/21 Checking commit f8f829a58306 (target/rx: Collect all bytes during disassembly) 13/21 Checking commit 31a1706ee141 (target/rx: Dump bytes for each insn during disassembly) 14/21 Checking commit e70e0f1b4562 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 14/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/21 Checking commit ed845484f284 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 15/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/21 Checking commit ece27860fa34 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 16/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/21 Checking commit bf58fbd6c21c (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 479 lines checked Patch 17/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/21 Checking commit 57763b04f473 (hw/rx: Honor -accel qtest) 19/21 Checking commit f313ac351c3b (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/21 Checking commit b1b44ed68088 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 20/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/21 Checking commit 1b70a2c5e3bf (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190618143923.53838-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com