On Mon, 9 Sep 2019 at 17:18, Dr. David Alan Gilbert <dgilb...@redhat.com> wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > Missing reset and VMState for migration. These should be > > baseline requirements for adding new device models to the > > tree, because in an ideal world every device would support > > both -- we should be gradually fixing the existing devices > > which are missing these, and not letting new devices in, > > so the situation gets gradually better, not worse. > > I'm happy to see things marked unmigratable instead for obscure > devices; I don't see the need to worry about migration for stuff > that's not going to be migrated.
VM snapshot save/restore is a useful debug tool. But yes, "mark as nonmigratable explicitly" is OK too -- at least that way if the user tries it they get a clear error message, and we can later on look through to find what devices are missing the capability. (Personally I find it's just as easy to just implement the vmstate struct, though.) thanks -- PMM
