On Wed, Dec 18, 2019 at 06:20:04PM +0100, Philippe Mathieu-Daudé wrote:
> The Chardev events are listed in the QEMUChrEvent enum. To be
> able to use this enum in the IOEventHandler typedef, we need to
> explicit all the events ignored by this frontend, to silent the
> following GCC warning:
>
> CC s390x-softmmu/hw/block/vhost-user-blk.o
> hw/block/vhost-user-blk.c: In function ‘vhost_user_blk_event’:
> hw/block/vhost-user-blk.c:370:5: error: enumeration value ‘CHR_EVENT_BREAK’
> not handled in switch [-Werror=switch]
> 370 | switch (event) {
> | ^~~~~~
> hw/block/vhost-user-blk.c:370:5: error: enumeration value
> ‘CHR_EVENT_MUX_IN’ not handled in switch [-Werror=switch]
> hw/block/vhost-user-blk.c:370:5: error: enumeration value
> ‘CHR_EVENT_MUX_OUT’ not handled in switch [-Werror=switch]
> cc1: all warnings being treated as errors
>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> ---
> v2: Add all missing enums
>
> Cc: "Michael S. Tsirkin" <m...@redhat.com>
> Cc: Kevin Wolf <kw...@redhat.com>
> Cc: Max Reitz <mre...@redhat.com>
> Cc: qemu-bl...@nongnu.org
Acked-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> hw/block/vhost-user-blk.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
> index 63da9bb619..ccaf2ad978 100644
> --- a/hw/block/vhost-user-blk.c
> +++ b/hw/block/vhost-user-blk.c
> @@ -383,6 +383,11 @@ static void vhost_user_blk_event(void *opaque, int event)
> s->watch = 0;
> }
> break;
> + case CHR_EVENT_BREAK:
> + case CHR_EVENT_MUX_IN:
> + case CHR_EVENT_MUX_OUT:
> + /* Ignore */
> + break;
> }
> }
>
> --
> 2.21.0
