Philippe Mathieu-Daudé <phi...@redhat.com> writes:
> The Chardev events are listed in the QEMUChrEvent enum. To be
> able to use this enum in the IOEventHandler typedef, we need to
> explicit all the events ignored by this frontend, to silent the
> following GCC warning:
>
> CC monitor/qmp.o
> monitor/qmp.c: In function ‘monitor_qmp_event’:
> monitor/qmp.c:345:5: error: enumeration value ‘CHR_EVENT_BREAK’ not handled
> in switch [-Werror=switch]
> 345 | switch (event) {
> | ^~~~~~
> monitor/qmp.c:345:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not
> handled in switch [-Werror=switch]
> monitor/qmp.c:345:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ not
> handled in switch [-Werror=switch]
> cc1: all warnings being treated as errors
>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> ---
> v2: Add all missing enums
>
> Cc: Markus Armbruster <arm...@redhat.com>
> ---
> monitor/qmp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/monitor/qmp.c b/monitor/qmp.c
> index b67a8e7d1f..6c46be40f8 100644
> --- a/monitor/qmp.c
> +++ b/monitor/qmp.c
> @@ -365,6 +365,11 @@ static void monitor_qmp_event(void *opaque, int event)
> mon_refcount--;
> monitor_fdsets_cleanup();
> break;
> + case CHR_EVENT_BREAK:
> + case CHR_EVENT_MUX_IN:
> + case CHR_EVENT_MUX_OUT:
> + /* Ignore */
> + break;
> }
> }
With the comment dropped:
Reviewed-by: Markus Armbruster <arm...@redhat.com>
