On 20/12/19 14:32, Marc-André Lureau wrote: > On Wed, Dec 18, 2019 at 9:20 PM Philippe Mathieu-Daudé > <phi...@redhat.com> wrote: >> >> Hi, >> >> After this chat on #qemu IRC: >> 13:20 <stsquad> so what is the difference between a IOReadHandler and >> IOEventHandler? >> 13:25 <f4bug> stsquad: one is in-band and the other out-of-band? >> 13:26 <stsquad> f4bug: ahh yes it seems so - connect/disconnect etc... >> 13:27 <f4bug> see QEMUChrEvent for IOEventHandler >> >> I thought it might be a good opportunity to make the IOEventHandler >> typedef meaning more obvious, by using the QEMUChrEvent enum. >> >> To be able to build I had to explicit all enums ignored in the >> switch(event) statement by these frontends. >> >> Then I used a coccinelle spatch to change the various IOEventHandler. >> I don't think the last patch can be split, but suggestions are welcome! >> >> Regards, >> >> Phil. >> >> v2: >> - do blindly ignore all events using a 'default' case. >> >> Philippe Mathieu-Daudé (14): >> hw/ipmi: Remove unnecessary declarations >> hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler >> hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler >> hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler >> hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler >> ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler >> vhost-user-crypto: Explicit we ignore some QEMUChrEvent in IOEventHandler >> vhost-user-net: Explicit we ignore few QEMUChrEvent in IOEventHandler >> vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler >> virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler >> monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler >> monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler >> chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler >> chardev: Use QEMUChrEvent enum in IOEventHandler typedef > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > (I guess Paolo will take the series for next PR?)
Yes, I'm queuing it. I'll check Richard's remark before sending out the pull request. Paolo
