Patchew URL: https://patchew.org/QEMU/20200212130311.127515-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v30 00/22] Add RX archtecture support Message-id: 20200212130311.127515-1-ys...@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200212023101.1162686-1-ebl...@redhat.com -> patchew/20200212023101.1162686-1-ebl...@redhat.com - [tag update] patchew/20200212130311.127515-1-ys...@users.sourceforge.jp -> patchew/20200212130311.127515-1-ys...@users.sourceforge.jp Switched to a new branch 'test' 63d8f29 qemu-doc.texi: Add RX section. 0828fee BootLinuxConsoleTest: Test the RX-Virt machine bea9ae2 Add rx-softmmu 46f27e3 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 2afce4c hw/rx: Honor -accel qtest ed93bfd hw/rx: RX Target hardware definition 72f4963 hw/char: RX62N serial communication interface (SCI) ad00efa hw/timer: RX62N internal timer modules bf6c82f hw/intc: RX62N interrupt controller (ICUa) 253d941 target/rx: Dump bytes for each insn during disassembly 0d816ca target/rx: Collect all bytes during disassembly bdfbcf3 target/rx: Emit all disassembly in one prt() f587124 target/rx: Use prt_ldmi for XCHG_mr disassembly eeca618 target/rx: Replace operand with prt_ldmi in disassembler 956befe target/rx: Disassemble rx_index_addr into a string 0835249 target/rx: RX disassembler 6821236 target/rx: CPU definition 0e76a8f target/rx: TCG helper fe37ab1 target/rx: TCG translation 7cc01ef hw/registerfields.h: Add 8bit and 16bit register macros d17802b qemu/bitops.h: Add extract8 and extract16 81462db MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 81462db667b2 (MAINTAINERS: Add RX) 2/22 Checking commit d17802b2bd09 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 7cc01ef2805e (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit fe37ab11655e (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 0e76a8f988a8 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 6821236f1ec6 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 659 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 083524988c91 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 956befec0bfb (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit eeca61803f65 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit f58712457dc7 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit bdfbcf35637b (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 0d816ca0983f (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 253d941aaa86 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit bf6c82fc3bcd (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit ad00efa8d314 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 72f4963a91f9 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 400 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit ed93bfd19986 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 ERROR: trailing whitespace #128: FILE: hw/rx/rx-virt.c:73: + $ ERROR: trailing whitespace #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into $ WARNING: Block comments use a leading /* on a separate line #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into WARNING: Block comments use * on subsequent lines #147: FILE: hw/rx/rx-virt.c:92: + /* The kernel image is loaded into + the latter half of the SDRAM space. */ WARNING: Block comments use a trailing */ on a separate line #147: FILE: hw/rx/rx-virt.c:92: + the latter half of the SDRAM space. */ total: 2 errors, 4 warnings, 493 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 2afce4c4ec24 (hw/rx: Honor -accel qtest) 19/22 Checking commit 46f27e3252e4 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit bea9ae2c5ed7 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 83 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 0828feec3de9 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 63d8f29d671c (qemu-doc.texi: Add RX section.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200212130311.127515-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com