Patchew URL: https://patchew.org/QEMU/20200212130311.127515-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v30 00/22] Add RX archtecture support Message-id: 20200212130311.127515-1-ys...@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20200212130311.127515-1-ys...@users.sourceforge.jp -> patchew/20200212130311.127515-1-ys...@users.sourceforge.jp Switched to a new branch 'test' 96043cc qemu-doc.texi: Add RX section. b7f311f BootLinuxConsoleTest: Test the RX-Virt machine d928a96 Add rx-softmmu 46a5463 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 3602010 hw/rx: Honor -accel qtest 0ab77aa hw/rx: RX Target hardware definition 6d8c7a0 hw/char: RX62N serial communication interface (SCI) b5b1aca hw/timer: RX62N internal timer modules ad8af53 hw/intc: RX62N interrupt controller (ICUa) b32635d target/rx: Dump bytes for each insn during disassembly 4363ee1 target/rx: Collect all bytes during disassembly 410e6f4 target/rx: Emit all disassembly in one prt() ed23672 target/rx: Use prt_ldmi for XCHG_mr disassembly 5701623 target/rx: Replace operand with prt_ldmi in disassembler fd886bb target/rx: Disassemble rx_index_addr into a string 1560408 target/rx: RX disassembler 0d304ec target/rx: CPU definition 57ca20a target/rx: TCG helper 003ca8c target/rx: TCG translation 79f2eaa hw/registerfields.h: Add 8bit and 16bit register macros 3148170 qemu/bitops.h: Add extract8 and extract16 79b00a8 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 79b00a820d7c (MAINTAINERS: Add RX) 2/22 Checking commit 3148170e9de8 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 79f2eaaec033 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 003ca8c0eb26 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 57ca20a306f9 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 0d304ec0ddd3 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 659 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 15604085897f (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit fd886bbd1449 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 5701623d0c7b (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit ed236724afd5 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 410e6f481e97 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 4363ee1bdef4 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit b32635d70232 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit ad8af53c7b71 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit b5b1aca6fd0b (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 6d8c7a072968 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 400 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 0ab77aad73ee (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 ERROR: trailing whitespace #128: FILE: hw/rx/rx-virt.c:73: + $ ERROR: trailing whitespace #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into $ WARNING: Block comments use a leading /* on a separate line #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into WARNING: Block comments use * on subsequent lines #147: FILE: hw/rx/rx-virt.c:92: + /* The kernel image is loaded into + the latter half of the SDRAM space. */ WARNING: Block comments use a trailing */ on a separate line #147: FILE: hw/rx/rx-virt.c:92: + the latter half of the SDRAM space. */ total: 2 errors, 4 warnings, 493 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 360201025f02 (hw/rx: Honor -accel qtest) 19/22 Checking commit 46a5463dc037 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit d928a9664d5d (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 83 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit b7f311fc5ce4 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 96043cc86d23 (qemu-doc.texi: Add RX section.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200212130311.127515-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
