Patchew URL: https://patchew.org/QEMU/20200212130311.127515-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v30 00/22] Add RX archtecture support Message-id: 20200212130311.127515-1-ys...@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200212130311.127515-1-ys...@users.sourceforge.jp -> patchew/20200212130311.127515-1-ys...@users.sourceforge.jp Switched to a new branch 'test' c07b5e4 qemu-doc.texi: Add RX section. d9e3115 BootLinuxConsoleTest: Test the RX-Virt machine b1722b2 Add rx-softmmu f88aff7 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core ce78c96 hw/rx: Honor -accel qtest 8097b53 hw/rx: RX Target hardware definition dbc2b8b hw/char: RX62N serial communication interface (SCI) 979446e hw/timer: RX62N internal timer modules 5a15247 hw/intc: RX62N interrupt controller (ICUa) f94a445 target/rx: Dump bytes for each insn during disassembly ca644b3 target/rx: Collect all bytes during disassembly 9d474c3 target/rx: Emit all disassembly in one prt() 95020f2 target/rx: Use prt_ldmi for XCHG_mr disassembly 5b536a9 target/rx: Replace operand with prt_ldmi in disassembler 7c95e62 target/rx: Disassemble rx_index_addr into a string 196b5bd target/rx: RX disassembler 9312a61 target/rx: CPU definition 4b9939c target/rx: TCG helper 3b8d86a target/rx: TCG translation 84337e2 hw/registerfields.h: Add 8bit and 16bit register macros 203f17b qemu/bitops.h: Add extract8 and extract16 08aca69 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 08aca69fecc7 (MAINTAINERS: Add RX) 2/22 Checking commit 203f17b55f7c (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 84337e272083 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 3b8d86a82898 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 4b9939cf24c9 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 9312a613ec1a (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 659 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 196b5bd702fc (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 7c95e627ab42 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 5b536a9efbaa (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 95020f2f8f2a (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 9d474c351686 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit ca644b362f6f (target/rx: Collect all bytes during disassembly) 13/22 Checking commit f94a445e6fb0 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 5a152470d6b2 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 979446eb0c51 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit dbc2b8bb6f23 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 400 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 8097b536c109 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 ERROR: trailing whitespace #128: FILE: hw/rx/rx-virt.c:73: + $ ERROR: trailing whitespace #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into $ WARNING: Block comments use a leading /* on a separate line #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into WARNING: Block comments use * on subsequent lines #147: FILE: hw/rx/rx-virt.c:92: + /* The kernel image is loaded into + the latter half of the SDRAM space. */ WARNING: Block comments use a trailing */ on a separate line #147: FILE: hw/rx/rx-virt.c:92: + the latter half of the SDRAM space. */ total: 2 errors, 4 warnings, 493 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit ce78c961bb0b (hw/rx: Honor -accel qtest) 19/22 Checking commit f88aff7a868d (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit b1722b2fe634 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 83 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit d9e311566e1e (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit c07b5e41a8d4 (qemu-doc.texi: Add RX section.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200212130311.127515-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
