On Mon, 27 Apr 2020 16:31:44 +0200
Eric Auger <eric.au...@redhat.com> wrote:
> The tpm-tis-device device does not support PPI. Let's
> change the default value for the corresponding property
> instead of tricking this latter in the mach-virt machine.
>
> Signed-off-by: Eric Auger <eric.au...@redhat.com>
> ---
> hw/tpm/tpm_tis_sysbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c
> index 18c02aed67..eced1fc843 100644
> --- a/hw/tpm/tpm_tis_sysbus.c
> +++ b/hw/tpm/tpm_tis_sysbus.c
> @@ -91,7 +91,7 @@ static void tpm_tis_sysbus_reset(DeviceState *dev)
> static Property tpm_tis_sysbus_properties[] = {
> DEFINE_PROP_UINT32("irq", TPMStateSysBus, state.irq_num, TPM_TIS_IRQ),
> DEFINE_PROP_TPMBE("tpmdev", TPMStateSysBus, state.be_driver),
> - DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, true),
> + DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, false),
> DEFINE_PROP_END_OF_LIST(),
> };
>
This looks like a better place to do this than in the virt compat
machines, and should get us the same result, leaving compatibility
intact.
Reviewed-by: Cornelia Huck <coh...@redhat.com>
