On Thu, 2 Jul 2020 at 13:23, Gerd Hoffmann <kra...@redhat.com> wrote: > > The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab: > > hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 > 21:16:10 +0100) > > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/modules-20200702-pull-request > > for you to fetch changes up to 474a5d66036d18ee5ccaa88364660d05bf32127b: > > chardev: enable modules, use for braille (2020-07-01 21:08:11 +0200) > > ---------------------------------------------------------------- > qom: add support for qom objects in modules. > build some devices (qxl, virtio-gpu, ccid, usb-redir) as modules. > build braille chardev as module. > > note: qemu doesn't rebuild objects on cflags changes (specifically > -fPIC being added when code is switched from builtin to module). > Workaround for resulting build errors: "make clean", rebuild. > > ---------------------------------------------------------------- > > Gerd Hoffmann (10): > module: qom module support > object: qom module support > qdev: device module support > build: fix device module builds > ccid: build smartcard as module > usb: build usb-redir as module > vga: build qxl as module > vga: build virtio-gpu only once > vga: build virtio-gpu as module > chardev: enable modules, use for braille
No code review at all? :-( In particular the "build: fix device module builds" commit (as you note in your commit message) does not look at all right. I would much prefer if we could get some code review for these changes before applying them. thanks -- PMM
