On 3/2/21 11:16 AM, Kevin Wolf wrote: > Most code paths for creating a user creatable object go through > QemuOpts, which ensures that the provided 'id' option is actually a > valid identifier. > > However, there are some code paths that don't go through QemuOpts: > qemu-storage-daemon --object (since commit 8db1efd3) and QMP object-add > (since it was first introduced in commit cff8b2c6). We need to have the > same validity check for those, too. > > This adds the check and makes it print the same error message as > QemuOpts on failure. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > This makes sense even without the -object QAPIfication, so no reason to > wait for v3 of that series to get this fixed. >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
