Am 06.03.2021 um 11:50 hat Paolo Bonzini geschrieben: > On 02/03/21 18:16, Kevin Wolf wrote: > > Most code paths for creating a user creatable object go through > > QemuOpts, which ensures that the provided 'id' option is actually a > > valid identifier. > > > > However, there are some code paths that don't go through QemuOpts: > > qemu-storage-daemon --object (since commit 8db1efd3) and QMP object-add > > (since it was first introduced in commit cff8b2c6). We need to have the > > same validity check for those, too. > > > > This adds the check and makes it print the same error message as > > QemuOpts on failure. > > > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > > --- > > This makes sense even without the -object QAPIfication, so no reason to > > wait for v3 of that series to get this fixed. > > It needs a check for id != NULL, but no big deal so I added it.
Oops, yes. Thanks for fixing it up. Kevin
