On Sat, Oct 22, 2022 at 22:15 Michael S. Tsirkin <m...@redhat.com> wrote:
> On Fri, Oct 21, 2022 at 09:47:04PM +0530, Ani Sinha wrote: > > > > > > On Fri, Oct 21, 2022 at 21:36 Alex Bennée <alex.ben...@linaro.org> > wrote: > > > > > > Ani Sinha <a...@anisinha.ca> writes: > > > > <snip> > > > > > > We have added a mirror of biosbits to the QEMU project so there > is no > > > reason why we can't track changes and modifications there (we do > this > > > for TestFloat which is forked from the upstream SoftFloat code). > > > > > > The whole idea was that say an acpi developer added support for a > new > > table in QEMU, he should write a corresponding > > > test for bits so that the same table is exercised during run time. > Making > > those changes from a single repo (either directly > > > or through a submodule) makes things lit simpler and also keeps > things > > in sync with each other. If we use separate > > > repos for acpi bits test, it will be another mess when comes to > > developers adding changes and keeping things in sync. > > > > > > Anyways these things should have been brought up earlier. I'm out > of the > > debate. > > > > > > I've sent v7 , incremental work over the last 6 months in my spare > time > > without getting any pay. So take it or scrap it. > > > > > > 😊 > > > > I'm sorry you feel that way but you asked for people to spend their > time > > reviewing your code and giving feedback. > > > > > > > > I’m sorry but you don’t understand. Giving feedback is one thing. Asking > people > > to make major changes to their design late in the game is completely not > > acceptable imho and outright rude. . I’ve been sending out the patch > series > > with cc to anyone who should remotely care about this stuff. So if major > rework > > is needed it should be pointed out earlier and not later. I’ve begged > people on > > irc even to take look at this stuff including Igor and others. What else > do you > > expect me to do? > > > > > > If you don't have time to take > > it forward then fine > > > > > > I’m extremely discouraged by this and have lost all motivation. It’s not > that I > > have no time. I squeeze all my spare time to work on this beyond my paid > > responsibilities. Please be respectful of that. > > > > > Woa I hope you'll get the motivation back. > > I feel more testing for acpi can only help, even if it is > limited to specific hosts at the moment. > > Let's start small, and build out. > > So IMHO major changes aren't strictly necessary to get this merged. > Alex sent a bunch of code review comments - do you think you can > address them? I’ve addressed them in v7. > The limitations and TODO should just IMHO be mentioned in the > cover letter and probably in comments in the code. > > Thanks! > > > > > > but I'm afraid a "take it or leave it" attitude > > will just result in it not getting merged. > > > > Hopefully someone else who has the time to look into it will be able > to > > pick it up later. > > > > -- > > Alex Bennée > > > >
