On Fri, Nov 04, 2022 at 10:55:39AM +0100, Drew DeVault wrote: > On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote: > > Splitting this big patch would ease review: > > It's only +165/-131, are you sure it really needs to be split?
IMHO it is a standard best practice that code movement always be done in a separate commit from bug fixes / new features, regardless of # lines of code affected. I've seen way too many patches where bugs have been hidden due code movement / whitespace changes mixed in, even when the patch was small. > > 1/ Replace safe_execve() by safe_execveat() > > > > -safe_execve(exec_path, argp, envp)) > > +safe_execveat(AT_FDCWD, exec_path, argp, envp, 0)); > > > > 2/ Extract do_execve() > > > > 3/ Convert do_execve() to do_execveat() adding dirfd/flags args > > > > 4/ Add TARGET_NR_execveat case > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
