Re: [PATCH v5 3/7] vfio/pci: Disable INTx in vfio_realize error path

[Cédric Le Goater]

On 6/30/23 09:36, Zhenzhong Duan wrote:

When vfio realize fails, INTx isn't disabled if it has been enabled.
This may confuse host side with unhandled interrupt report.

Fixes: c5478fea27ac ("vfio/pci: Respond to KVM irqchip change notifier")
Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com>

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.

---
  hw/vfio/pci.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index ab6645ba60af..31c4ab250fbe 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3220,6 +3220,9 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)
      return;

out_deregister:

+    if (vdev->interrupt == VFIO_INT_INTx) {
+        vfio_intx_disable(vdev);
+    }
      pci_device_set_intx_routing_notifier(&vdev->pdev, NULL);
      if (vdev->irqchip_change_notifier.notify) {
          kvm_irqchip_remove_change_notifier(&vdev->irqchip_change_notifier);