Hi Peter, On 9/22/23 17:29, Peter Maydell wrote: > Avoid shadowing a variable in smmuv3_notify_iova(): > > ../../hw/arm/smmuv3.c: In function ‘smmuv3_notify_iova’: > ../../hw/arm/smmuv3.c:1043:23: warning: declaration of ‘event’ shadows a > previous local [-Wshadow=local] > 1043 | SMMUEventInfo event = {.inval_ste_allowed = true}; > | ^~~~~ > ../../hw/arm/smmuv3.c:1038:19: note: shadowed declaration is here > 1038 | IOMMUTLBEvent event; > | ^~~~~ > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > hw/arm/smmuv3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c > index 1e9be8e89af..6f2b2bd45f9 100644 > --- a/hw/arm/smmuv3.c > +++ b/hw/arm/smmuv3.c > @@ -1040,8 +1040,8 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr, > SMMUv3State *s = sdev->smmu; > > if (!tg) { > - SMMUEventInfo event = {.inval_ste_allowed = true}; > - SMMUTransCfg *cfg = smmuv3_get_config(sdev, &event); > + SMMUEventInfo eventinfo = {.inval_ste_allowed = true}; > + SMMUTransCfg *cfg = smmuv3_get_config(sdev, &eventinfo); > SMMUTransTableInfo *tt; > > if (!cfg) { Reviewed-by: Eric Auger <eric.au...@redhat.com>
Thanks! Eric