On 9/22/23 17:29, Peter Maydell wrote:
> Avoid shadowing a local variable in do_process_its_cmd():
>
> ../../hw/intc/arm_gicv3_its.c:548:17: warning: declaration of ‘ite’ shadows a
> previous local [-Wshadow=compatible-local]
> 548 | ITEntry ite = {};
> | ^~~
> ../../hw/intc/arm_gicv3_its.c:518:13: note: shadowed declaration is here
> 518 | ITEntry ite;
> | ^~~
>
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
> hw/intc/arm_gicv3_its.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
> index 5f552b4d37f..52e9aca9c65 100644
> --- a/hw/intc/arm_gicv3_its.c
> +++ b/hw/intc/arm_gicv3_its.c
> @@ -545,10 +545,10 @@ static ItsCmdResult do_process_its_cmd(GICv3ITSState
> *s, uint32_t devid,
> }
>
> if (cmdres == CMD_CONTINUE_OK && cmd == DISCARD) {
> - ITEntry ite = {};
> + ITEntry i = {};
> /* remove mapping from interrupt translation table */
> - ite.valid = false;
> - return update_ite(s, eventid, &dte, &ite) ? CMD_CONTINUE_OK :
> CMD_STALL;
> + i.valid = false;
> + return update_ite(s, eventid, &dte, &i) ? CMD_CONTINUE_OK :
> CMD_STALL;
> }
> return CMD_CONTINUE_OK;
> }
Reviewed-by: Eric Auger <eric.au...@redhat.com>
Eric
