On Fri, 9 Apr 2021 at 17:21, Peter Petrik <[email protected]> wrote: > > Hi, > > First of all, thanks Nyall for your efforts. I try to review the code that we > introduced to QGIS and I find kind-of familiar: for example QgsQuick, > MeshLayer or MacOS stuff. But as mentioned in the thread, the less you know > the particular code, the more time it takes to review it. What I see that I > can improve is to actively at least twice per week double check the PR queue > to see if there is something in this area, since sometimes I need to be > pinged to get a notification in email that the PR is waiting for review. > > What are my thoughts on other improvements not mentioned by Nyall and others: > 1. when someone introduces a new feature (and most notably coming from a paid > contract), the review process should be taken into account in the quote and > the reviewer should be notified. Proper review can take days...
I agree... but realistically, how often is this done? In the 10 years I've had merge rights I've been paid **once** to review a big PR. I'd be interested to hear other's experiences here. (Personally I'll always include a disclaimer in my quotes that that work has to go through peer review and may be blocked by the larger community. And then I'll trade on social capital or trade review-for-review in order to get my PRs reviewed as quickly as possible. I've also never directly paid anyone external for a review.) Nyall _______________________________________________ QGIS-Developer mailing list [email protected] List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
