[ 
http://team.ops4j.org/browse/QI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18203#comment-18203
 ] 

Paul Merlin commented on QI-361:
--------------------------------

Niclas,

I took some time to understand what this issue is really about.

I think that the actual code fulfill the issue expressed here that I understand 
as "ValueBuilderInstance instances can not be reused". ValueCompositeBasicsTest 
and ValueCompositeTest now demonstrate this. Moreover, using JDK classes as 
mixins is demonstrated in JDKMixinTest and I created QI-376 to track this.

On the other hand I think that MapOverrideTest is more about QI-298, the 
performance concern should be in a dedicated issue and could be postponed to 
2.1.

So I think this very issue (QI-361) can be closed.

Did I miss something?
Please correct me if I'm wrong.

Cheers

/Paul
                
> "ValueBuilder instances can not be reused."
> -------------------------------------------
>
>                 Key: QI-361
>                 URL: http://team.ops4j.org/browse/QI-361
>             Project: Qi4j
>          Issue Type: Bug
>          Components: Core Runtime
>            Reporter: Niclas Hedhman
>             Fix For: 2.0 - Reductionism
>
>
> If you try to use the same ValueBuilder as a cookie-cutter for similar 
> values, you will receive the error; 
> java.lang.IllegalStateException: ValueBuilder instances cannot be reused
> This defeats the purpose of having the methods prototype() and prototypeFor().
> So, either the names need to change (I don't like that), or the previous 
> behavior of prototype instantiation should be supported.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
http://team.ops4j.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

_______________________________________________
qi4j-dev mailing list
[email protected]
http://lists.ops4j.org/mailman/listinfo/qi4j-dev

Reply via email to