Flavio Castelli <[email protected]> writes:
> I've just pushed to master some changes that should fix all the historical
> problems qjson had with cmake.
>
> The biggest difference now is that find_package(QJSON) won't work anymore as
> only a lowercase config file will be installed (so one should do
> find_package(qjson)).
>
> Let me know if something has to be changed, I would like to release a new
> version of QJson within the next days.
As the author of these CMake changes, I have a few comments after
thinking of these commits again:
- find_package(QJSON) still works, CMake is smart enough to find
${CMAKE_PREFIX_PATH}/lib/cmake/qjson and the lowercase
qjson-config.cmake there.
- The current changes will probably break most projects which use CMake
and qjson: according to lxr.kde.org and google code search, most (if
not all) projects link to QJSON_LIBRARIES and
QJSON_INCLUDE_DIR. However, as the code currently is (ie. with the
project name set to lowercase "qjson"), the variables are now called
qjson_LIBRARIES and qjson_INCLUDE_DIR. This can be fixed by changing
the project name in the top-level CMake file to QJSON or hardcoding
the variable names in qjson-config.cmake.in to QJSON_FOO without
using CMAKE_PROJECT_NAME or simply setting these variables after the
current ones in qjson-config.cmake.in. I think the first solution is
the smallest one.
------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
QJson-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qjson-devel
