On Wednesday, August 24, 2011 06:08:18 PM Flavio Castelli wrote:
> I've just pushed to master some changes that should fix all the historical
> problems qjson had with cmake.
> 
> The biggest difference now is that find_package(QJSON) won't work anymore as
> only a lowercase config file will be installed (so one should do
> find_package(qjson)).

Wrong.

>From the cmake documentation:

| The command searches for a file called "<name>Config.cmake" or
|  "<lower-case-name>-config.cmake" for each name specified. 

So every upper/lowercase combination you can think of will work. 

find_package(QJson)
find_package(qJsOn)

will all work. Please consider to not use the lower-case variant. Instead use 
QJson-config.cmake or anything else with at least one UpperCase Letter to 
enforce some consistency here and make it possible to add/use a find module in 
future (see kde-buildsystem "Re: Buildsystem TODO list" alex neundorf 24.08).

There is an error too. The solution does not work on lib64 btw. because it 
fails to account for LIB_SUFFIX when installing qjson-config.cmake.in

Please change this in the root CMakeLists.txt (85++):

INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/qjson-config.cmake
              ${CMAKE_CURRENT_BINARY_DIR}/qjson-config-version.cmake
        DESTINATION "lib/cmake/qjson")

to 

INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/qjson-config.cmake
              ${CMAKE_CURRENT_BINARY_DIR}/qjson-config-version.cmake
        DESTINATION "${CMAKECONFIG_INSTALL_DIR}")


Mike

------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
QJson-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qjson-devel

Reply via email to