Flavio Castelli <[email protected]> writes: > On Wednesday 24 August 2011 18:40:32 Michael Jansen wrote: >> Please consider to not use the lower-case variant. Instead >> use QJson-config.cmake or anything else with at least one UpperCase Letter > > So I just have to rename qjson-config.cmake to QJson-config.cmake, > right?
If you do this, find_package(QJSON), which is what most applications do, will look for QJSONConfig.cmake and qjson-config.cmake, and will not find either of them. Since mjansen recommends against using qjson-config.cmake, I suggest renaming qjson-config.cmake to QJSONConfig.cmake -- this should guarantee that find_package(QJSON) will still work and that the lower-case, catch-all version will not be used, so a FindQJSON.cmake provided elsewhere does not have the troubles mjansen described. > [...] > Is there anything else I should change? * The ChangeLog needs to be adjusted, as find_package(QJSON) will still work. * project(qjson) in the top-level CMakeLists.txt should become project(QJSON). There are other ways to solve this as I described in another post, but this is the most simple way IMO. ------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev _______________________________________________ QJson-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qjson-devel
