Hi, I do not agree with the idea of having samples under src/examples. Samples (with their READMEs) are an important part of learning the product for a new user and should be easily visible for them to be useful. Having them deep under src/examples is definitely not going to help them, while having the samples, along-with their associated READMEs, under the distribution will be clearly visible to them. This is also useful especially when user's want to install the binary distribution (with sample source) and are not interested (at-least initially) with the complete source distribution.
Obviously there won't be any new JARs added because of this, only the sample source files in the distribution. I have done some work on creating samples (with READMEs) for Qpid under the distribution, and happy to add them later this week / early next week. In the meanwhile I am creating a JIRA issue to track the same. Suresh -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Martin Ritchie Sent: Wednesday, December 13, 2006 3:15 AM To: [email protected] Subject: Re: new client examples On 13/12/06, Steve Vinoski <[EMAIL PROTECTED]> wrote: > Hi Marnie, today you added the client/example directory, but I'm a > little puzzled by it, because I don't know what it's intended for. > One issue is that it's not part of the main build, so it will not > appear as part of any distribution. Another issue is that I don't > think it should be part of the main build -- only the sources and the > tests should be. > > I'd therefore like to suggest that any samples/examples/demos be put > under the distribution directory, so they can be included in qpid > distributions, as I assume we want them to be, without requiring them > to be part of the main build. I'd be happy to move them if you like. I don't think the examples should be part of the distribution build. This just seems unintuitive. I would have suggested they should either be in src/examples part of the main build, but then delivered to everyone, or as they are in a separate sub-module of client. That can be included in a distribution but can also be distributed separately. The distribution directory is already so full of jars that we never had or needed pre-maven. I'd like to see us moving towards a set of distributions that contain the minimal files required to run a broker, a client and for development that contains everything. The only problem I can see currently is that if we include the examples in the distribution then as they are not part of the main build the distribution build will fail because it copies whatever files are in your local repository. I don't know maven that well but is there ANY way we can change this? Only dependencies should be pulled from the local repository. The qpid code should be compiled "locally" and included in the distribution. I can't believe that maven forces you to only work on one "revision" of the code base at a time. I have a number of branches in development and having to do a main clean and install before I can build a distribution seems so unintuitive. This issue doesn't seem to bother some on the list but I am finding it increasingly annoying. Does anyone else share this opinion? -- Martin Ritchie
