Robert Spier wrote:
(Side note, John, your newsreader is not doing nice things to the mail
headers.)

(Sorry, Mozilla mail, you know. :o Care to be specific and I'll open a ticket with them?)


There's a namespace issue, because there are potentially multiple
results from multiple callbacks.

Oh, did you fix the multiple instance plugin problem then? Remember I discovered that I couldn't sucessfully run two different queue/qmail-queue instances with different parameters (I'm experimenting with qmqp).



$self->transaction->notes( $code->{name})->{"hook_$hook"}->{'return'}

is what i've implemented and checked into trunk

I see, you are worried about multiple returns from different callbacks from a single plugin. Still, if the multiple plugin instance problem is fixed (above), then you'll have namespace collisions again...


BTW, is trunk working again, then? When I checked it out yesterday, I discovered that some of the hooks were not running (like none of the check* modules would fire). I had to back out the last set of changes, since I had stupidly sync'd and smerged (Yes, I am using svk! Ask me how(TM)!).

Clearly, the project policy is not that trunk is always [mostly] functional (ouch). Once I finish up this stupid mail conversion (400 users and many gigabytes of mail), I'll try and spend a little time writing more tests (and maybe a Makefile.PL to make it easier to do the tests).

John

p.s. is anyone interested in seeing VRFY actually do something for specific remote hosts? I have a crude hack so my remote MX boxes can refuse mail for non-local accounts, but it could easily be changed into a more elegant hook.

Reply via email to