On Fri, 22 Jan 2016, Paul Jakma wrote:
On Fri, 22 Jan 2016, Donald Sharp wrote:
I disagree that we shouldn't use them though, I think they are good
especially when someone different is committing them then who authored the
work. Especially if several people worked on the patch in question.
The problem is that it's a string that gets cargo-culted around the
open-source world, which gets added just cause that seems to be what others
are doing, or cause the patch-herder told you to add it to get your patch
committed (without saying why), or even cause patch-herders are adding on
your behalf apparently!
So there isn't a reasonably well-understood common understanding of what its
presence signifies, which means is does not serve a purpose. Which means it
is just pure useless overhead at present.
Oh, E.g. "Authored by" is something a lot of other people would not
think "signed off by" meant.
Because of this kind of thing, all SOB achieves (in Quagga anway) at
present is muddying the waters for everyone. For that reason, I'd
suggest not using it at all.
regards,
--
Paul Jakma [email protected] @pjakma Key ID: 64A2FF6A
Fortune:
I never killed a man that didn't deserve it.
-- Mickey Cohen
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
