Paul,
On 25 Aug 2016, at 4:00, Paul Jakma wrote:
On Tue, 23 Aug 2016, Martin Winter wrote:
How about changing the build system (configure.ac I assume) to just
use always C99 mode?
It does. It sets that when it can.
The thing is, if you supply a CFLAGS then that always overrides what
was set - and I think that's automake, so nothing we can do in
configure.ac. And it seems some of the CI system runs stuff that does
that. Mostly in building packages. So it'll do the build, that works,
then build packages - which starts a build from scratch in the ones I
looked at - and some of those set CFLAGS but don't set -std=c99.
I thought the general idea is NOT to use CFLAGS for this and fix
configure.ac.
See
http://stackoverflow.com/questions/11647208/where-to-add-a-cflag-such-as-std-gnu99-into-an-autotools-project
They suggest to put
AC_PROG_CC_STDC
after
AC_PROG_CC
Did my way to build packages break this?
- Martin
Suggestion: Just do make dist and build the package from that. The
package build tests the build, so a build before that isn't necessary
- just adds further RTT to getting the patches through the CI.
As for CFLAGS in some of the package systems, not sure. Debian seems
one as do some of the BSDs. Probably GCC version related too? (Maybe
newer gccs don't error on C99 'for (<declaration>..) by default?).
regards,
--
Paul Jakma | [email protected] | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
Never volunteer for anything.
-- Lackland
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
