On Fri, 30 Sep 2016, Lou Berger wrote:

The change I submitted continues the original use of NHT information for
Idle (start event) and Active (retry) states, i.e., just removes NHT
info in Connect state.

Bug-wise it is just the bgp_connect_check call that needs to go.

In which case, that would just that leaves Active and Connect doing the same thing: Raising ConnectRetry_timer_expired.

Keeping these event sources seems fine (at least based on testing) and not clear to me very significant, but I haven't traced through all the possible generation of NHT events.

It was just coming from zebra - Nexthop-update message. The one in testing is the initial message when bgpd starts up after it has registered the peer.

I have no strong option on keeping the original event mapping code or the intro of an NHT event - I can see arguments for/against both. But I'm not comfortable with the into of the new transitions at this point - certainly I'm skeptical about the change in Connect and OpenXXX states.

Which change?

There's no changes to OpenXXX?

regards,
--
Paul Jakma | [email protected] | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
The major difference between bonds and bond traders is that the bonds will
eventually mature.

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to