Hi Lou,

On Fri, 30 Sep 2016, Paul Jakma wrote:

On Thu, 29 Sep 2016, Lou Berger wrote:

 looks like the NHT code is generating an event into the state machine
 that it shouldn't be.  I removed this and checked it into my work
 area.   See
 
https://github.com/LabNConsulting/quagga-vnc/commit/7162337f9261b91056b95a673a54ad595aef3e5f

 Kudos to Martin for logs/pcaps/discussion and the system that id'ed this
 issue and will verify the fix.

Yeah, I'd come to the same conclusion yesterday with my own test-case (again based on logs and pcaps from Martin) and emailed him. :)

So, I have:

  http://git.savannah.gnu.org/cgit/quagga.git/commit/?id=26943e36

The whole bgp_fsm_nht_update can just be removed, and this second NHT-dedicated, mini-sub-FSM removed and the event handled via the main FSM.

Indeed, is it even necessary to tickle Active/Connect connections to make them reconnect cause of an NHT event? In which case, the fix is just removing code.

?

regards,
--
Paul Jakma | [email protected] | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
An exotic journey in downtown Newark is in your future.

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to