On Fri, May 20, 2005 at 02:11:16PM -0400, David Binger wrote:
> Modified:
>    trunk/quixote/http_response.py
> Log:
> Remove charset option from HTTPResponse.set_content_type().
> Calling it without a charset had the surprising effect of setting the
> charset to iso-8859-1.
> If you want to set the charset on the response, call set_charset().
> This is not backward compatible.

I don't think I agree with this change.  set_content_type() worked
like that for a reason.  Usually when you call set_content_type()
you are changing the content-type to something non-text (e.g. an
image).  In that case you want the charset to be iso-8859-1.  You
don't want the response to be encoded using DEFAULT_CHARSET.  If you
want some ofher charset then you really should provide it explicitly
to the set_content_type() call.

  Neil
_______________________________________________
Quixote-users mailing list
[email protected]
http://mail.mems-exchange.org/mailman/listinfo/quixote-users

Reply via email to