On Fri, May 20, 2005 at 02:51:13PM -0400, David Binger wrote:
> What should be the result of this?
>   response.set_charset('utf-8')
>   response.set_content_type('text/rss+xml')
> The intent is clear, but the result is a surprise.
> 
> I think the charset parameter should either be required for all
> calls to set_content_type(), or else it should not be present.

In retrospect, it should always be required.  Maybe we could emit a
warning if it is not provided.

> Doesn't changing the charset because "most" calls are for images
> seem a little speculative and a lttle magical?

Yes.  The change you made is not any better though, IMHO.

> Besides, the DEFAULT_CHARSET *is* iso-8859-1, right?

If someone is using a different charset (e.g. utf-8) I would expect
them to call set_charset() inside the root directory's _q_traverse
or monkey patch HTTPResponse.DEFAULT_CHARSET.

  Neil
_______________________________________________
Quixote-users mailing list
[email protected]
http://mail.mems-exchange.org/mailman/listinfo/quixote-users

Reply via email to