Thanks Paulo, this is way better than the workflow I used the only other time I made a PR. The only thing I had to do was choose a branch to commit to: I chose 'master', mostly because I have no clue what else I would have chosen. What is the default to contribute to?
It was in scribblings by the way. Cheers, Marc On Thu, Mar 7, 2019 at 12:02 PM 'Paulo Matos' via Racket Users < racket-users@googlegroups.com> wrote: > > > On 07/03/2019 11:55, Marc Kaufmann wrote: > > Hi, > > > > I just came across a typo in the documentation and was about to move on > > simply because I couldn't be bothered to figure out how/where to change > > it. I couldn't find the docs in the github repo (I searched for doc, and > > looked under racket-lang-org without success). > > > > Also, is there a guide on best practice for pull requests or > > contributions, including a "Fork this, do that, push like that, etc"? I > > have no idea, usually just fork the whole thing, but don't know how to > > keep it up-to-date. Pointers to Racket-agnostic resources very welcome. > > Thanks, > > Marc > > > > PS: I am purposefully not saying where the typo is so that I will have > > to go and fix it, rather than have someone else fix it. > > > > Where the documentation is, depends on where the typo is. Is it in the > Guide, Reference, somewhere else? > > Go to https://github.com/racket/racket > then search for the typo in the github search box and select 'in this > repository'. > > Found it, great? No? Maybe the docs are somewhere else. Does it belong > to one of the libraries in pkgs.racket-lang.org? To scribble? > > Once you found it, the easiest thing for a typo is to find the file in > github, then edit straight in github. It will automatically fork the > project. Then you can edit the file, fixing the typo and commit. Open PR > straight after that. Someone will come and merge the PR. :) If you need > step-by-step help feel free to pvt me in Slack. > > Enjoy the ultimate pleasure of committing to the racket repo, go get > that chocolate bar you deserve! > > -- > Paulo Matos > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Racket Users" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/racket-users/J8ylMGGGr-8/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > racket-users+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Racket Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to racket-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
