@pablobm commented on this pull request.
> However, due to persistent local Docker and networking environment issues on
> my Windows machine, I was unable to capture final browser screenshots for
> this submission
Are you using the instructions given in
[DOCKER.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/doc/DOCKER.md)
or
[DEVCONTAINER.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/doc/DEVCONTAINER.md)?
What errors are you seeing? If you can't see the results yourself, working on
frontend issues is not going to be sustainable, unfortunately.
For now, I had a look. The tags table is sticky, which depending on the page
can obscure the whole content below. For example, if the screen is not tall, or
the tags table is very tall, there's very little (if any) space left below for
any other content.
https://github.com/user-attachments/assets/2d0a56e4-6ce3-471b-8482-9160e9cb0928
> @@ -1,4 +1,4 @@
-<%= tag.div :class => ["mb-3 border-bottom border-secondary-subtle pb-3",
+<%= tag.div :class => ["mb-3 border-bottom border-secondary-subtle pb-3
browse-container",
What is this class? It's not used anywhere else, or defined anywhere I can see.
Is it a hallucination?
> @@ -1045,3 +1045,4 @@ img.trace_image {
.layer-info-toggle {
mix-blend-mode: difference;
}
+
Please make sure not to include unnecessary changes.
> @@ -7,9 +7,12 @@
:redaction_link => link_to(t("browse.redacted.redaction",
:id => way.redaction.id),
way.redaction) %>
<% else %>
- <%= render :partial => "browse/common_details", :object => way %>
+ <div class="sticky-top bg-body">
What's the `bg-body` for?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6767#pullrequestreview-3759777667
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6767/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
