pablobm left a comment (openstreetmap/openstreetmap-website#6837)
That sounds reasonable to me. I'm always wondering what's a good way to present
these types of changes. I tend to have those commits that do just the
generation (as you have seen) in order to clarify the provenance of the code.
However this can be done too in code comments and commit descriptions, which I
have done now.
While at it, I have added a couple of methods, `Changeset#visible_subscribers`
and `ChangesetComment#notifiable_subscribers` in order to reduce the number of
indirections in the `recipients` section of `ChangesetCommentNotifier`.
Finally, I have updated Noticed to v3.0.0. Can't remember why it was 2.9.3, I
guess I started this experiment before it was published? In any case, the
changes between the two versions are not significant:
https://github.com/excid3/noticed/compare/v2.9.3...v3.0.0
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6837#issuecomment-4082097177
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6837/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
