@tomhughes commented on this pull request.
> @@ -55,4 +55,18 @@ def test_body_valid
assert_not_predicate changeset_comment, :valid?, "#{body} is valid when
it shouldn't be"
end
end
+
+ def test_notifiable_subscribers
+ commenter1 = create(:user)
+ commenter2 = create(:user, :suspended)
+ commenter3 = create(:user)
+ commenter4 = create(:user)
+ changeset = create(:changeset)
+ create(:changeset_subscription, :changeset => changeset, :subscriber =>
commenter1)
+ create(:changeset_subscription, :changeset => changeset, :subscriber =>
commenter2)
+ create(:changeset_subscription, :changeset => changeset, :subscriber =>
commenter3)
Should we be subscribing `commenter4` here as well, so that we are checking
that it excludes the author from the list of notifiable subscribers?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6837#pullrequestreview-3969989472
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6837/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
