tomhughes left a comment (openstreetmap/openstreetmap-website#6837)
> That sounds reasonable to me. I'm always wondering what's a good way to
> present these types of changes. I tend to have those commits that do just the
> generation (as you have seen) in order to clarify the provenance of the code.
> However this can be done too in code comments and commit descriptions, which
> I have done now.
I think it makes some sense to break things down like that while you're
developing it but I'm not sure it's hugely helpful once you're happy with it.
Personally if I'm adding something new like that I tend to maybe run the
generator to get an idea of what things should look like but then build
something I like rather than necessarily using the output verbatim but I
realise not everybody will be the same on that.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6837#issuecomment-4082143750
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6837/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
