@hlfan commented on this pull request.
> @@ -75,10 +75,12 @@
</div>
</div>
<% else %>
- <div class="d-inline-flex btn-group login-menu">
- <%= link_to t(".log_in"), login_path(:referer => request.fullpath),
:class => "geolink btn btn-outline-secondary" %>
- <%= link_to t(".sign_up"), new_user_path, :class => "btn
btn-outline-secondary" %>
- </div>
+ <% unless allow_signup == false %>
I suggested that already, and while I still don't really get "why it doesn't
make sense to invert the logic" to have a `disallow_signup` or `hide_signup`
here, and how that relates to "arguing with google", imo the nil fallback route
is still cumbersome.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7138#discussion_r3376218600
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7138/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
