@simonpoole commented on this pull request.
> @@ -75,10 +75,12 @@
</div>
</div>
<% else %>
- <div class="d-inline-flex btn-group login-menu">
- <%= link_to t(".log_in"), login_path(:referer => request.fullpath),
:class => "geolink btn btn-outline-secondary" %>
- <%= link_to t(".sign_up"), new_user_path, :class => "btn
btn-outline-secondary" %>
- </div>
+ <% unless allow_signup == false %>
The point is that we are just trying to use something that is established for
this purpose and not invent something new (which for example has the advantage
that you don't need to have different code for authorising with github and
osm), what I've done now is that I've renamed the instance variable and
inverted the logic that sets it.
Naturally that loc still hurts my brain, but it is 1 place vs 2.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7138#discussion_r3376355761
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7138/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
