@tomhughes requested changes on this pull request.
> @@ -5,7 +5,7 @@
<%= render "layouts/head", :title => @title, :opengraph_properties =>
@opengraph_properties %>
<%= tag.body :class => body_class,
:data => { :map_theme =>
current_user&.preferred_color_scheme(:map, :site) } do %>
- <%= render :partial => "layouts/header" %>
+ <%= render :partial => "layouts/header", :locals => {
:allow_signup => @allow_signup } %>
Something has inserted a load of extra whitespace here.
> @@ -75,10 +75,12 @@
</div>
</div>
<% else %>
- <div class="d-inline-flex btn-group login-menu">
- <%= link_to t(".log_in"), login_path(:referer => request.fullpath),
:class => "geolink btn btn-outline-secondary" %>
- <%= link_to t(".sign_up"), new_user_path, :class => "btn
btn-outline-secondary" %>
- </div>
+ <% unless allow_signup == false %>
Why the double negative? Why not just:
```suggestion
<% if allow_signup %>
```
> @@ -11,14 +11,16 @@
<% end %>
<div class="d-flex align-items-end">
- <ul class="nav nav-tabs fs-6">
- <li class="nav-item">
- <%= link_to t("sessions.new.tab_title"), "#", :class => "nav-link
active" %>
- </li>
- <li class="nav-item">
- <%= link_to t("users.new.tab_title"), url_for(:action => :new,
:controller => :users, :referer => params[:referer]), :class => "nav-link" %>
- </li>
- </ul>
+ <% unless @allow_signup == false %>
```suggestion
<% if @allow_signup %>
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7138#pullrequestreview-4452186794
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7138/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
