gravitystorm left a comment (openstreetmap/openstreetmap-website#7215)

I don't think this is worthwhile, unfortunately, even though I can see why you 
might want it.

There's no point in changing the url to the geofabrik server, without also 
changing the title and the description. It's a specific company with a specific 
url, it's not a generalised service.

It's also worth noting that the overpass link isn't generic - the UI adds 
location information to that url, in an overpass-specific format, and that 
doesn't happen for the other urls.

I guess in theory a third-party installation of this codebase could have a list 
of their own 4 alternative download locations, and just change the titles, 
descriptions and urls for each of them to something else (and ignore the names 
in the keys). Something like

```yaml
    planet:
      title: "Planet OpenExampleSite"
      description: "Regularly-updated copies of the complete OpenExampleSite 
database"
    overpass:
      title: "OverSomething API"
      description: "Download this bounding box from a mirror of the 
OpenExampleSite database"
    geofabrik:
      title: "Some other location"
      description: "Some other description"
    ...
```

But there's no guarantee that the OpenExampleSite needs exactly four locations, 
and that one of those locations is an overpass url, and what if we add a fifth 
link, and so on. So really we're talking about a much bigger level of 
customisation, and we don't support that.

However, I'd suggest a compromise version, where we move the URLs out of the 
view and into the translation system. We do that already with a lot of other 
unlikely-to-really-need-translation urls, so there is precedent there.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/7215#issuecomment-4913836490
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/issues/7215/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to