1ec5 left a comment (openstreetmap/openstreetmap-website#7215)
> However, I'd suggest a compromise version, where we move the URLs out of the
> view and into the translation system. We do that already with a lot of other
> unlikely-to-really-need-translation urls, so there is precedent there.
For reference, here’s how we handle the list of resources on the Help page,
which instances can customize:
https://github.com/openstreetmap/openstreetmap-website/blob/6b60b50d366b3440445091487b9d82b76a34817a/app/views/site/help.html.erb#L7
https://github.com/openstreetmap/openstreetmap-website/blob/dfdedc9b231bfa8e43099096731c6d630b25fa51/config/locales/en.yml#L2686-L2722
By the way, the translation YAMLs are the biggest source of merge conflicts and
bad merges for OHM and probably any nontrivial fork of this codebase. After
several messes, OHM wound up choosing different identifiers in `sites` that
don’t overlap with the upstream identifiers, to ensure that translators
wouldn’t copy over irrelevant titles and URLs from Translatewiki.net’s
translation memory of openstreetmap-website.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/7215#issuecomment-4919113343
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/7215/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
