Thank you very very much, iain.

> I have one question though, why do you exclude created_at and
> updated_at from the generated model translations? Why shouldn't they
> be translated?

I believe these columns are "system columns" just for framework-
internal use, and should not be revealed to the end users,
thus not needed to be translated as well.
If you need a timestamped column in your application code, you might
add another datetime column with values updated explicitly (not
automatically by the framework).

> next unless m.ancestors.include? ActiveRecord::Base
>
> into:
>
> next unless m.respond_to?(:content_columns)

Thank you! Committed your enhancement!

> I also found one bug: when you specify translations for virtual
> attributes, they get removed by the generator from the file, which
> shouldn't be happening.

Ah, yes. I agree it's a very big problem.
I'm gonna maka a fix somehow.

And, let me ask you one more thing.
Do you mind if I use your Translated scaffold templates to provide
i18n_scaffold generator?
Actually, it's already been implemented
http://github.com/amatsuda/i18n_generators/tree/master/generators/i18n_scaffold
but not yet included in the gem.

Akira

On 11月28ζ—₯, 午後7:40, iain hecker <[EMAIL PROTECTED]> wrote:
> Hi,
>
> Fantastic work Akira, I really love it!
>
> I have one question though, why do you exclude created_at and
> updated_at from the generated model translations? Why shouldn't they
> be translated?
>
> Furthermore I have one little alteration: on line 14 of
> i18n_models_command.rb[1], can you change
>
> next unless m.ancestors.include? ActiveRecord::Base
>
> into:
>
> next unless m.respond_to?(:content_columns)
>
> This makes it a lot easier to add translations which are not based on
> ActiveRecord. I can adjust my ActsAsTranslatableModel plugin[2] to
> work in concert with your generator.
>
> I also found one bug: when you specify translations for virtual
> attributes, they get removed by the generator from the file, which
> shouldn't be happening.
>
> Anyway, Keep up the good work!
>
> Iain Heckerhttp://iain.nl/
>
> [1]http://github.com/amatsuda/i18n_generators/tree/master/generators/i18...
> [2]http://iain.nl/2008/09/acts_as_translatable_model-plugin/
>
> On Nov 28, 8:51 am, Akira Matsuda <[EMAIL PROTECTED]> wrote:
>
> > Hello.
>
> > I updated the i18n_generators gem.
> > Now it conforms to the Rails 2.2.2 official way of i18n config (use
> > environment.rb and config/locales/*.yml), and fetches the .yml file
> > from Sven's rails-i18n repository (thanks for adopting my jp.yml,
> > Sven).
>
> > > PanosJee
>
> > Sorry for my late reply.
>
> > > Does your gem find the other string symbols from the yaml or views
> > > files and appends them to the new locales ?
>
> > > In that that case does it also translate form them Google or we have
> > > to add them on our own ?
>
> > No, I'm sorry, that function is not yet implemented.
> > I just added your request to my TODO list (in my mind), so maybe it's
> > gonna be implemented someday...
>
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"rails-i18n" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/rails-i18n?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to