> -----Original Message----- > From: Robert Burrell Donkin [mailto:[email protected]] > Sent: Wednesday, 17 June 2009 6:34 AM > To: [email protected] > Subject: Re: RAT with BuildBot at Apache
<snip> > > i've refactored the code and added a simple example (--exclude which > uses Commons IO wildcard file filters). Woohoo, excellent thanks! And it works just great. Buildbot picked up the new code and deployed the new Jar into operation just a minute or so after you made the commit :) All I needed to do then was add my excludes to the rat.conf build file, then wait some seconds whilst Saxon converted the resultant xml report into html and then deployed to the website for viewing. I love it when it all works. http://ci.apache.org/projects/rat/rat-report.html Is the up to date HTML report -- as mentioned the HTML could do with a bit of tweaking to pretty it up and make it worthwhile looking at over the txt version. Which I'll do soon to get it out of the way. The important thing here is we now have useful and accurate reports. Using the RAT report above, we have 9 unknown licenses. Unknown licenses includes no license at all so may need to re-word that, anyway .. Of those 9 licenses Empty.txt, notjavadoc.html, bad.txt, src.txt -- are all intentionally not licensed and are there as examples. So that leaves us with 5 possible 'real' contenders in RAT for license problems. BUILD.txt - I don't see why we can't add a licence header here, others do. src/main/java/org/apache/rat/report/claim/ClaimStatistic.java src/main/java/org/apache/rat/report/claim/impl/AbstractClaimReporter.java src/main/java/org/apache/rat/report/claim/impl/ClaimAggregator.java src/test/resources/elements/Source.java All those look like genuine contenders to have licences added. Shall I attach a patch somewhere for those 5 ? Then I believe we are 'clean' and ready to act as a good example :) > i'd be happy to review a patch > for something along the lines of your suggestion (i've refactored the > code so it should be easier to do now - just take a look at the > excludesimplementation in > http://svn.apache.org/repos/asf/incubator/rat/main/trunk/apache-rat- > core/src/main/java/org/apache/rat/Report.java) Great, I'll take a look at that soon, thanks. > > > > While I'm here, I'm now just playing with ant-task-examples.xml but I > can't > > get it working. I renamed it to build.xml and tried to use it as is. > > > > The error I get is :- > > > > D:\Apache2\rat-trunk>ant javasources > > Buildfile: build.xml > > > > -taskdef: > > > > javasources: > > > > BUILD FAILED > > D:\Apache2\rat-trunk\build.xml:33: Problem: failed to create task or > type > > antlib > > :org.apache.rat.anttasks:report > > Cause: The name is undefined. > > Action: Check the spelling. > > Action: Check that any custom tasks/types have been declared. > > Action: Check that any <presetdef>/<macrodef> declarations have taken > place. > > No types or tasks have been defined in this namespace yet > > > > This appears to be an antlib declaration. > > Action: Check that the implementing library exists in one of: > > -D:\Apache2\forrest\tools\ant\lib > > -C:\Documents and Settings\Gavin\.ant\lib > > -a directory added on the command line with the -lib argument > > > > I'm assuming user error, any clues? > > i think that you either need to install the rat antlib locally (see ant > manual since it's fiddly) or add a classpath containing the jars required Yeah I figured something like that, Ant's site is a nightmare and I can never find what jar I need that is required for 'antlib', I'll keep looking, thanks. Gav... > > - robert >
