> -----Original Message----- > From: Gavin [mailto:[email protected]] > Sent: Thursday, 15 October 2009 8:16 PM > To: [email protected] > Subject: RE: RAT with BuildBot at Apache > > > > > -----Original Message----- > > From: David Crossley [mailto:[email protected]] > > Sent: Thursday, 15 October 2009 10:25 AM > > To: [email protected] > > Subject: Re: RAT with BuildBot at Apache > > > > Gav... wrote: > > > David Crossley wrote:
<snip> > > > > I was trying to help you with the Ant task, not > > the commandline. > > > > It seems to me that the Ant task would have better > > abilities to "exclude" stuff. > > Ok, I give in, I'll do it that way. I would have preferred to have > specified > the excludes in a command line argument from within the python build > script. > > This way I have to create separate build.xml files on the filesystem, > messy > in my opinion, as all the build directories for the builds are wiped clean > each time and a fresh svn checkout provided, so I can not place the ant > tasks file in the same place as the rest of the build. > > Working on it now, thanks for the hints. > Ok, I have it working now. http://ci.apache.org/projects/forrest/rat-output.txt That is upto date using the ant task and a forrest.xml build file, which contains excludes for all the files/dirs from the forrest license-avoid.txt file. So we are down to 111, but I do see more than can be excluded. I think it will be easy for me to convert that list (license-avoid.txt) into a list of <exclude name="xxx"/> and have that in an external file, that way it will dynamically update whenever that file changes. So, my last question for the list in this particular saga. How would I include that external file list into the build file into th right place? So from: <fileset dir="${src-dir}"> <exclude name=".buildbot-sourcedata"/> <exclude name="admin/"/> <exclude name="lib/"/> ... </fileset> to something like: <fileset dir="${src-dir}"> -external file list of excludes goes here- </fileset> I'm looking at loadfile but not sure if that is appropriate. Thanks Gav... > Gav... > > > > > > -David > > > > > RAT63 will already be applied as Buildbot always compiles the latest > > > snapshot from RAT trunk, so buildbot is using the latest, including > > > the above fix. > > > > > > so, > > > > > > --exlcude somefile.name somefirstLevelDir/ someotherdir/ > > > > > > does work > > > > > > but, > > > > > > --exclude firstLevel/secondlevel/file.name firstLevel/secondLevel/** > > > > > > does not. > > > > > > I can not use the maven way I dont think. > > > > > > > I am keen to help because Buildbot/RAT is giving > > > > Forrest a bad rap due to known exclusions not being > > > > sufficiently configured. > > > > > > Yes, and now having mentioned it on the infra list again this is my > > > number one priority, I apologise,but I have mentioned the problem > above > > > on this list before and not had a specific reply to cure it. I hope > > > someone can offer ideas, but i will try again to get it working > myself. > > No virus found in this incoming message. > > Checked by AVG - www.avg.com > > Version: 8.5.421 / Virus Database: 270.14.17/2436 - Release Date: > 10/14/09 > > 18:32:00 > > No virus found in this incoming message. > Checked by AVG - www.avg.com > Version: 8.5.421 / Virus Database: 270.14.17/2436 - Release Date: 10/15/09 > 03:57:00
