Gavin wrote: > > > > Ok, I have it working now. > > > > http://ci.apache.org/projects/forrest/rat-output.txt > > > > That is upto date using the ant task and a forrest.xml build file, which > > contains excludes for all the files/dirs from the forrest license- > > avoid.txt > > file. So we are down to 111, but I do see more than can be excluded. > > > > I think it will be easy for me to convert that list (license-avoid.txt) > > into > > a list of <exclude name="xxx"/> and have that in an external file, that > > way > > it will dynamically update whenever that file changes. > > > > So, my last question for the list in this particular saga. > > > > How would I include that external file list into the build file into th > > right place? > > > > So from: > > > > <fileset dir="${src-dir}"> > > <exclude name=".buildbot-sourcedata"/> > > <exclude name="admin/"/> > > <exclude name="lib/"/> > > ... > > </fileset> > > > > to something like: > > > > <fileset dir="${src-dir}"> > > -external file list of excludes goes here- > > </fileset> > > > > I'm looking at loadfile but not sure if that is appropriate. > > For the archives etc, 'excludesfile' is my friend, so I now have: > > <fileset dir="${src-dir}"> > <excludesfile name="${src-dir}/etc/relicense-avoid.txt"/> > <exclude name=".buildbot-sourcedata"/> > <exclude name="**.htaccess"/> > </fileset> > > and it reads the .txt as is, brilliant.
Beauty. One hitch in Forrest's case. That etc/relicense-avoid.txt is not a list of Ant-style patterns, it is a crude list of exact text patterns for my old relicense.pl script. So perhaps the RAT file should be "rat-avoid.txt" or "rat-exclude.txt" and we just have duplicate similar files for each purpose. Should i go ahead and create that file for Forrest? > Apologies David for taking so long, No worries. Glad that we could get RAT processing improved. > and so long to realise that actually, > the ant task way of doing it, is actually better in this scenario now. > > RAT and Buildbot combo are now once again, much more useful. > > Gav... Yep, fantastic ... thanks too to Ant. -David
