-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The tests have to be run manually and so should be easy to find by downloaders (apart from reading the README). Ate's suggestion is good, except I would prefer something like "trunk/installation-tests/selenium" over etc.
Marlon On 8/18/11 9:20 AM, Ciancetta, Jesse E. wrote: >>> Added: incubator/rave/trunk/rave-portal/rave-selenium-tests/ >>> incubator/rave/trunk/rave-portal/rave-selenium-tests/README.txt >>> incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-Gadgets- >> >>> Workout >>> incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-Login-Test >>> >>> incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-New- >> Account-Test >>> incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-OpenID- >> >>> Test >>> incubator/rave/trunk/rave-portal/rave-selenium-tests/Rave-Selenium- >> >>> Tests >>> >> I think its great to have these selenium tests but storing them >> under rave-portal folder would not be my preference. >> >> I'd rather would like to keep these separate from the direct code >> bases, like for instance under: >> incubator/rave/trunk/etc/selenium-tests/ >> >> WDYT? > > I agree that they should be moved, but I'm not sure that we > necessarily need to move them out from under rave-portal. > > Are you thinking that they span more than just the rave-portal > application code (since the rave-portal code ends up running our > shindig extension code) and as such should be placed at a higher > level? I guess that makes some sense to me, but on the other hand it > seems like the tests themselves are all about testing the rave-portal > web interface and the fact that they end up exercising some of our > shindig extension code seems like an implementation detail that we > might not need to represent in our SVN structure. > > I'm thinking that putting them under rave-portal/test might be > another alternative: > > incubator/rave/trunk/rave-portal/src/test/selenium > > or maybe /test/webapp/selenium to be more consistent with the > structure under the main tree (although I don’t think I like this as > much): > > incubator/rave/trunk/rave-portal/src/test/webapp/selenium > > WDYT? > >> Regards, >> >> Ate -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOTRPzAAoJEEfVXEODPFID+DkH/iP3zcDNZ5E/FvFu/78CJMLp po9hPLyxQP00/2AMxOx+49I7Al1XxYfefVhu3xdXu78JrBijHTo/udXYkCPeCykb Rvqktxw+daVR9E3HJeFch1CG0Ac8bMbqKgZcoQK3GZZJJKWkO7ILBL4WLLOB0i1j HGbaTFj1JRw7KPTvgY30ekpBWlm5x4JfSNhY11cVbVJvLtPgmdJc8yyrUhLSIGuY qlmbKZzHNuv6V0jaGecvmTP2yoljX+OmPxIhmX0IPex23mm4yTXccvj1IYHzmSIY hFj4Rz8/lJP9IygO4G+gZEqMdW6tdtq4y1lNxeC1BLyA7EiVspaBdyNjZCb9an0= =Bn8H -----END PGP SIGNATURE-----
